Use the Docker Build Kit platform vars #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Docker Build Kit exports the target OS and architecture as build args so we can use them instead of assuming linux/amd64. https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope Signed-off-by: Dave Shawley <daves@aweber.com>
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: dave-shawley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Docker Build Kit exports the target OS and architecture as build args so we can use them instead of assuming linux/amd64. The default values are set to
linux/amd64in case you are building in a docker version that does not have build kit available. You may also need to setDOCKER_BUILDKIT=1for it to exportTARGETOSandTARGETARCHcorrectly.I'm not sure what incantations are required in the Github actions to build on ARM as well as Intel but this should "just work" if you are building on an ARM CPU. This is a start to addressing #147 though additional CI work is required.
https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope