Update wdio config #4068
Update wdio config #4068
Conversation
wdio.conf.js
Outdated
|
|
||
| const wdioConfig = defaultWdioConfig.config; | ||
| config.specs = ['./packages/**/wdio/**/*-spec.js']; |
There was a problem hiding this comment.
Will this break on windows? We're not using path.join anymore to normalize between POSIX vs non-POSIX.
Do we also still need to strip out the @cerner stuff from package names?
There was a problem hiding this comment.
All the other scripts are also unix based and we use devcontainers for windows development anyway so this shouldn't affect it.
The @cerner/ stripping is to convert the package name to the folder name, which I am now doing directly using a glob.
wdio.conf.js
Outdated
|
|
||
| const wdioConfig = defaultWdioConfig.config; | ||
| config.specs = ['./packages/**/wdio/**/*-spec.js']; |
There was a problem hiding this comment.
Do we no longer need "tests" in the path? It appears to be there in the wdioConfig.specs path on line 9
There was a problem hiding this comment.
Oh, good catch! Updated here: 07d8bf4
Interestingly, it still worked for some reason.
There was a problem hiding this comment.
It would still work because the packages/** would cover any directory structure in between. It just would not limit to the specific path that was in place before.
Summary
This PR simplifies the wdio config and does so miscellaneous code cleanup.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
Thank you for contributing to Terra.
@cerner/terra