This repository has been archived by the owner on May 24, 2024. It is now read-only.
Support Checkbox selection by label without passed id #4067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroshk
approved these changes
Mar 20, 2024
sycombs
approved these changes
Mar 20, 2024
|
Functionally reviewed, looks good @cm9361 |
|
I also received approval from @mjpalazzo from the Accessibility Review so I will merge the functionality. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
The Terra Form Checkbox was updated to generate the necessary id, when not passed as a prop, so that the ability to toggle the input field via the label would work in that scenario.
Why it was changed:
The change was made to ensure that the label could be used to toggle the input field (checkbox) in all scenarios.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
N/A
This PR resolves:
UXPLATFORM-10317
Thank you for contributing to Terra.
@cerner/terra