This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-button] Add Left Alignment Property #4066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if I'm just missing it (having trouble expanding/collapsing files in Github today) but should we also add a WDIO test for the left aligned button since there is a visual difference? |
|
I did add a test to the long text test for WDIO. I am noticing that maybe the full page is not in the screen shot |
sdadn
approved these changes
Mar 19, 2024
adoroshk
approved these changes
Mar 19, 2024
|
I received approval from @mjpalazzo so I will move forward with merging this update. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
A property was added to the Terra Button to allow consumers the ability to left align the content.
Why it was changed:
The change was made so that button content could be aligned properly for the MPages Fusion library.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
N/A
This PR resolves:
UXPLATFORM-10278
Thank you for contributing to Terra.
@cerner/terra