This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-list] Fixed focus issue when clicked on selectable item in draggable list item example #4054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change should be at the component level not in an example |
899c36b to
17da97f
Compare
fb4a527 to
27aa1ed
Compare
Updated. |
sugan2416
reviewed
Mar 8, 2024
packages/terra-list/CHANGELOG.md
Outdated
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| * Fixed | |||
| * Fixed the issue where focus was not moving to the selected item when clicked in the draggable list item example. | |||
There was a problem hiding this comment.
Suggested change
| * Fixed the issue where focus was not moving to the selected item when clicked in the draggable list item example. | |
| * Fixed the issue where focus was not moving to the selectable and draggable item when clicked. |
There was a problem hiding this comment.
Updated 2b1b080
sugan2416
reviewed
Mar 8, 2024
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| * Added | |||
| * Added new test example for `terra-list`. | |||
There was a problem hiding this comment.
Suggested change
| * Added new test example for `terra-list`. | |
| * Added new test example for draggable list items in `terra-list`. |
There was a problem hiding this comment.
Updated f0b498d
sugan2416
reviewed
Mar 8, 2024
There was a problem hiding this comment.
There is existing example for draggable list item :https://github.com/cerner/terra-core/blob/main/packages/terra-core-docs/src/terra-dev-site/test/list/DraggableListItem.test.jsx
This can be used to test the change
There was a problem hiding this comment.
Updated 2b1b080
268ee68 to
2b1b080
Compare
15f95b0 to
f0b498d
Compare
sugan2416
approved these changes
Mar 8, 2024
saket2403
approved these changes
Mar 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, when clicking on a selectable list item in the draggable list item example, the focus was not moving to the clicked item. With this fix, the issue has been resolved, and now we are able to focus on the selected item.
What was changed:
Fixed the issue where focus is not moving to the selected item when clicked.
Why it was changed:
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10247
Thank you for contributing to Terra.
@cerner/terra