This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-list] Reverted refCallback from div to li #4053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you make the same changes in List SubsectionHeader as well here(https://github.com/cerner/terra-core/blob/main/packages/terra-list/src/ListSubsectionHeader.jsx#L113-L115) |
@saket2403 , Changed for ListSubsectionHeader component |
saket2403
approved these changes
Mar 5, 2024
sugan2416
reviewed
Mar 5, 2024
Co-authored-by: Sugan G <sugan.guts@gmail.com>
sugan2416
approved these changes
Mar 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Restored the
refCallbackprop for the ListSectionHeader and ListSubsectionHeader components to be applied to the intendedlielement instead of the innerdivtag.Why it was changed:
This aligns with the correct purpose of the prop as specified in both the source code and Terra documentation.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10248
Thank you for contributing to Terra.
@cerner/terra