This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-alert] Add ID prop #4048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroshk
approved these changes
Feb 28, 2024
cm9361
approved these changes
Feb 29, 2024
|
@sycombs - I validated keyboard navigation and JAWS screen reader are working as required. I can only confirm the Terra doc site examples are still working. Were you looking for me to do a regression test and confirm that everything works as before? If there is more testing I should do, please let me know. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an
idprop toterra-alertso that consumers are able to access the ID of the notification banner title in order to associate the banner with action elements.Testing
This change was tested using:
Tested with Voiceover and JAWS using the action button example on the About page.
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
Thank you for contributing to Terra.
@cerner/terra