This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-hyperlink] Fixed hyperlink import path error #4045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenk2
approved these changes
Feb 27, 2024
|
do we also need to fix this in the other 7 packages with this same import? |
No because this is the only package that imports from terra-theme-properties:
|
|
hah! fair enough! :)
|
JessieRandle
approved these changes
Feb 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR tweaks the scss import path in terra-hyperlink to resolve a potential "path not found" error by webpack.
Adding a
~at the start causes webpack to recognize the path as a node_module.PatrickJS/PatrickJS-starter#727
Testing
This change was tested using:
This was tested by running
npm startand ensuring that the dev site still compiles.Reviews
In addition to engineering reviews, this PR needs:
Additional Details
Thank you for contributing to Terra.
@cerner/terra