This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-section-header] Fixes header title width for sticky header #4043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Can you check the focus borders, they are getting cut off in the test you added. |
This is expected behaviour since header is under horizontal scroll |
cb143ff to
9ffc633
Compare
saket2403
approved these changes
Feb 28, 2024
|
@eawww @ShettyAkarsh @saket2403 UX suggestions (if any) will be addressed in a separate PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Sets width of header title element when section headers are bounded by width and have sticky header.
Why it was changed:
This fixes issue when auto width was set to collapsible section headers causing the onclick action to fail due to insufficient size of clickable area of section-header.
Sticky headers which are bounded have width set to bounded width, else set to auto.
Non-sticky headers have width as 100%
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10215
Thank you for contributing to Terra.
@cerner/terra