This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-button] Focus Glow getting cut off when used inside clinical header and table #4040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saket2403
reviewed
Feb 23, 2024
| @@ -39,7 +39,7 @@ | |||
| font-size: var(--terra-button-font-size, 1rem); | |||
| justify-content: center; | |||
| line-height: var(--terra-button-line-height, 1.429); | |||
| margin: 0; /* Reset margin for Safari. Safari defaults to 2px. */ | |||
| margin: 2px; /* Reset margin for Safari. Safari defaults to 2px. */ | |||
There was a problem hiding this comment.
This comment can be removed. Since we are no longer setting the margin to 0
There was a problem hiding this comment.
Done.
9eda7ee
Thanks
saket2403
approved these changes
Feb 23, 2024
sdadn
approved these changes
Feb 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Changed the default margin value of button.
Why it was changed:
The blue focus glow gets cut off when the utility button is used inside the clinical header with the orion-fusion theme.
Even in terra-table if the cell has button content the focus glow gets cut off when focused.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10195
Thank you for contributing to Terra.
@cerner/terra