This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-form-select] - Fix select option width and styling #4023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdadn
reviewed
Feb 8, 2024
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| * Changed | |||
| * Changed --terra-form-select-option-padding value to the orion-fusion-theme to match consistent padding. | |||
There was a problem hiding this comment.
Suggested change
| * Changed --terra-form-select-option-padding value to the orion-fusion-theme to match consistent padding. | |
| * Changed --terra-form-select-option-padding value to match with the orion-fusion-theme for consistency. |
Comment on lines
-278
to
-297
| /** | ||
| * Sets the hovered option as the active value. | ||
| * @param {event} event - The mouse enter event. | ||
| * @param {ReactNode} option - The option that received the mouse enter event. | ||
| */ | ||
| handleMouseEnter(event, option) { | ||
| // Prevents setting the active option on mouse enter if the keyboard scrolled the view. | ||
| if (this.scrollTimeout) { | ||
| return; | ||
| } | ||
|
|
||
| if (!option.props.disabled) { | ||
| this.setState({ active: option.props.value }); | ||
| } | ||
|
|
||
| if (option.props.onMouseEnter) { | ||
| option.props.onMouseEnter(event); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I understand that this is now being handled by CSS but will this cause any loss of functionality?
There was a problem hiding this comment.
This functionality will add only is-active class on mouse hover, now this being handled by CSS, and this won't cause any loss of functionality.
adoroshk
approved these changes
Feb 8, 2024
Yes, focus styling is now different from hover, we have matched same onHover and onFocus style as other terra components. |
sdadn
approved these changes
Feb 23, 2024
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Why it was changed:
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10121
Thank you for contributing to Terra.
@cerner/terra
Befor fix :
After fix :