This repository has been archived by the owner on May 24, 2024. It is now read-only.
Apply redwood theme #4018
Merged
Apply redwood theme #4018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroshk
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
I am not sure why it looks like there is an example missing on the top line of this png?
There was a problem hiding this comment.
There is a link missing. However, this is the same behavior seen in the existing tests. We might need to reevaluate the unit test and how the snapshot is captured. I can log a JIRA, if desired.
There was a problem hiding this comment.
Just double-checking to ensure that overlay looks as expected and should not have any text?
There was a problem hiding this comment.
Great question. This path shows that text should not be present: raw/tests/cerner-terra-core-docs/overlay/overlay/default-overlay
artpark
approved these changes
Jan 23, 2024
sycombs
approved these changes
Jan 23, 2024
sdadn
approved these changes
Jan 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
The Terra Badge, Base, Card, Divider, Hyperlink, Image, Overlay, and Signature components were updated to support the Redwood theme
Why it was changed:
The change was made to start the rebranding of our solutions to match Oracle standards.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10149
UXPLATFORM-10031
UXPLATFORM-10011
UXPLATFORM-10009
UXPLATFORM-10003
UXPLATFORM-9987
UXPLATFORM-9950
Thank you for contributing to Terra.
@cerner/terra