Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-list] Updated Drag and Drop example to select list items. #4008

Merged
merged 5 commits into from
Jan 11, 2024

Conversation

MadanKumarGovindaswamy
Copy link
Contributor

@MadanKumarGovindaswamy MadanKumarGovindaswamy commented Jan 9, 2024

Summary

What was changed:

Draggable List Item Example has been updated to include state

Why it was changed:

There was no state to select the list item.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-10112


Thank you for contributing to Terra.
@cerner/terra

@github-actions github-actions bot temporarily deployed to preview-pr-4008 January 9, 2024 10:30 Destroyed
@MadanKumarGovindaswamy MadanKumarGovindaswamy changed the title [terra-list] Drag and Drop not working as expected for selectable list items. [terra-list] Updated Drag and Drop example to select list items. Jan 9, 2024
@github-actions github-actions bot temporarily deployed to preview-pr-4008 January 9, 2024 13:37 Destroyed
@MadanKumarGovindaswamy MadanKumarGovindaswamy marked this pull request as ready for review January 9, 2024 13:45
@MadanKumarGovindaswamy MadanKumarGovindaswamy requested a review from a team as a code owner January 9, 2024 13:45
adoroshk

This comment was marked as resolved.

@MadanKumarGovindaswamy
Copy link
Contributor Author

I observed following behavior. If I navigate to the item via keyboard, then press SPACE, the (staying on the same item), press Enter, it errors Screenshot 2024-01-09 at 3 22 19 PM Screenshot 2024-01-09 at 3 25 04 PM

-- Handled this error.
Thanks

@github-actions github-actions bot temporarily deployed to preview-pr-4008 January 10, 2024 05:20 Destroyed
@cerner cerner deleted a comment from github-actions bot Jan 10, 2024
@saket2403 saket2403 merged commit 8ddac22 into main Jan 11, 2024
22 checks passed
@saket2403 saket2403 deleted the UXPLATFORM-10112-ListDraggableExampleDoc branch January 11, 2024 11:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants