Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[Terra-Form-Field] Added Inline label examples for form field components #4001

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

supreethmr
Copy link
Contributor

@supreethmr supreethmr commented Dec 20, 2023

Summary

This PR updates Following field components doc example to demonstrate creation of inline label field component

  • terra-form-input-field
  • terra-form-single-select-field
  • terra-form-combobox-field
  • terra-form-native-select-field

What was changed:
New examples are created to demonstrate creation of inline label field component

Why it was changed:
Mpage Fusion Field components supports inline label this was raised as Gap after pass through. Hence creating examples to demonstrate creation of inline label field component.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-9853


Thank you for contributing to Terra.
@cerner/terra

@supreethmr supreethmr self-assigned this Dec 20, 2023
@supreethmr supreethmr requested a review from a team as a code owner December 20, 2023 13:39
@ShettyAkarsh
Copy link
Contributor

can we try to fix this gap between the label and the input in the example ?

image

@github-actions github-actions bot temporarily deployed to preview-pr-4001 January 2, 2024 08:31 Destroyed
@supreethmr
Copy link
Contributor Author

can we try to fix this gap between the label and the input in the example ?

image

Space was added due to terra-grid, Replaced terra-grid with flex-box div to reduce space between label and input
Screenshot 2024-01-02 at 2 01 28 PM

@supreethmr supreethmr merged commit d750eda into main Jan 4, 2024
22 checks passed
@supreethmr supreethmr deleted the inline-field-labels branch January 4, 2024 14:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants