This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-button] Updated doc for isselected button #3999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supreethmr
reviewed
Dec 19, 2023
Comment on lines
26
to
29
| ### Assistive Technology Support | ||
| #### WAI ARIA Roles and States | ||
| * [aria-pressed](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-pressed) | ||
| * With Safari and Chrome, VoiceOver screenreader is partially compatible with aria-pressed. When aria-pressed is set to true, VoiceOver announces the selection state; when aria-pressed is set to false, it fails to announce the de-selection state. |
There was a problem hiding this comment.
Let's move this section below props table for consistency
supreethmr
approved these changes
Dec 19, 2023
saket2403
approved these changes
Dec 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Updated doc on
aria-pressedfor isSelected buttonWhy it was changed:
Added details regarding
aria-pressedlimitation in VoiceOver.Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-XXXX
Thank you for contributing to Terra.
@cerner/terra