This repository has been archived by the owner on May 24, 2024. It is now read-only.
Added ariaDescription prop for terra list #3993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supreethmr
reviewed
Dec 11, 2023
Comment on lines
4
to
5
| * Updated | ||
| * Added `ariaDescription` example added for terra-list |
There was a problem hiding this comment.
Suggested change
| * Updated | |
| * Added `ariaDescription` example added for terra-list | |
| * Changed | |
| * Reverted `Removed ariaDescription example added for terra-list` |
supreethmr
reviewed
Dec 11, 2023
packages/terra-list/CHANGELOG.md
Outdated
Comment on lines
4
to
5
| * Updated | ||
| * Added `ariaDescription` prop in list |
There was a problem hiding this comment.
Suggested change
| * Updated | |
| * Added `ariaDescription` prop in list | |
| * Changed | |
| * Reverted `Removed ariaDescription prop from list`. |
supreethmr
reviewed
Dec 11, 2023
| @@ -200,9 +200,6 @@ const ListSection = ({ | |||
| style: getStyleforDrag(ListItem, snapshot, provider), | |||
| }); | |||
|
|
|||
| /* eslint-disable-next-line no-param-reassign */ | |||
| delete customProps?.isTabFocusDisabled; | |||
There was a problem hiding this comment.
why are you reverting this change ..??
supreethmr
reviewed
Dec 11, 2023
Comment on lines
+4
to
+5
| * Changed | ||
| * Reverted `Removed ariaDescription prop from list`. |
There was a problem hiding this comment.
Need to line space for consistency
Suggested change
| * Changed | |
| * Reverted `Removed ariaDescription prop from list`. | |
| * Changed | |
| * Reverted `Removed ariaDescription prop from list`. |
supreethmr
reviewed
Dec 11, 2023
Comment on lines
4
to
5
| * Updated | ||
| * Added `ariaDescription` prop in list |
There was a problem hiding this comment.
Suggested change
| * Updated | |
| * Added `ariaDescription` prop in list | |
| * Changed | |
| * Reverted `Removed ariaDescription prop from list`. |
supreethmr
approved these changes
Dec 11, 2023
nikhitasharma
approved these changes
Dec 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
ariaDescriptionprop has been included in the Terra List component.What was changed:
Added
ariaDescriptionprop to terra-listWhy it was changed:
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9893
Thank you for contributing to Terra.
@cerner/terra