Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-search-field] Added invalid red box for invalid search field #3986

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

udaymattam
Copy link
Contributor

@udaymattam udaymattam commented Nov 27, 2023

Summary

What was changed:
added validation for terra-search-field. For every invalid search (empty search) added validation (red box) been triggered

Screenshot 2023-11-30 at 3 38 49 PM

Why it was changed:

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-XXXX


Thank you for contributing to Terra.
@cerner/terra

@udaymattam udaymattam self-assigned this Nov 27, 2023
@udaymattam udaymattam marked this pull request as ready for review November 28, 2023 06:40
@udaymattam udaymattam requested a review from a team as a code owner November 28, 2023 06:40
@supreethmr
Copy link
Contributor

Screenshot 2023-11-30 at 11 02 18 AM

This example is not providing required information about invalid state of search field ( like when search field will be at invalid state on click of set search field text button ?? )

@github-actions github-actions bot temporarily deployed to preview-pr-3986 December 6, 2023 05:20 Destroyed
@supreethmr supreethmr merged commit 57bd0a6 into main Dec 6, 2023
21 checks passed
@supreethmr supreethmr deleted the invalid-example branch December 6, 2023 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants