This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-form-search-select] Added error message for invalid example #3980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supreethmr
reviewed
Nov 22, 2023
| @@ -67,6 +67,7 @@ | |||
| --terra-form-select-toggle-invalid-box-shadow: 0 0 0 1px #fb4c4c; | |||
| --terra-form-select-toggle-invalid-focus-border-color: #004c76; | |||
| --terra-form-select-toggle-invalid-focus-box-shadow: 0 0 0 1px #004c76, 0 0 0 1px #004c76; | |||
| --terra-form-select-error-text-color: #fb4c4c; | |||
There was a problem hiding this comment.
why do you need this variable ..?
supreethmr
reviewed
Nov 22, 2023
| }; | ||
|
|
||
| const handleFocus = () => { | ||
| setInvalidText('Please select a color'); |
There was a problem hiding this comment.
this should be default message and you need to clear it onchange !!
isInvalid should be updated back to true when user clears the value from dropdown
There was a problem hiding this comment.
This is not required since we have removed the clear selection prop
supreethmr
reviewed
Nov 22, 2023
| <> | ||
| <SearchSelect | ||
| placeholder="Select a color" | ||
| isInvalid={isInvalid} |
There was a problem hiding this comment.
we should also add aria-invalid attribute for search-select-input control whenever isInvalid is set to true.
There was a problem hiding this comment.
It was already added in some other PR
supreethmr
reviewed
Nov 30, 2023
supreethmr
approved these changes
Nov 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added error message for invalid example and instruction text to test the error message. Previously there is no error message for invalid example. With this change we have added error message and made border color dynamic to check the error state is working correctly or not.
What was changed:
Added error message and instruction text to validate invalid example.
Why it was changed:
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9841
Thank you for contributing to Terra.
@cerner/terra