This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-form-search-select] Added visual focus dashed border for list options #3979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supreethmr
reviewed
Nov 22, 2023
| @@ -77,6 +77,7 @@ | |||
|
|
|||
| .is-active { | |||
| background-color: var(--terra-form-select-option-active-background-color, #ebf6fd); | |||
| border: var(--terra-form-select-option-active-color-border, 2px dashed #000); | |||
There was a problem hiding this comment.
this should be outline and outline-offset I think not a border !!
supreethmr
reviewed
Nov 23, 2023
| @@ -77,6 +77,8 @@ | |||
|
|
|||
| .is-active { | |||
| background-color: var(--terra-form-select-option-active-background-color, #ebf6fd); | |||
| outline: var(--terra-form-select-option-active-color-outline, 2px dashed #000); | |||
| outline-offset: var(--terra-form-select-option-active-color-outline-offset, -2px); | |||
There was a problem hiding this comment.
this variable does not have references in other themes. do we need this variable..?
There was a problem hiding this comment.
Yes, outline-offset value is same for remaining themes, hence i haven't added the outline-offset variable in other themes.
There was a problem hiding this comment.
then there is no use of the declaring css var --terra-form-select-option-active-color-outline-offset !!
supreethmr
approved these changes
Nov 29, 2023
|
+1 for the focus indicator which is visible when we navigate to the options in the list. |
f1d1a9b to
9c7377d
Compare
f29b004 to
5418872
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
previously there is no visual focus indication for list options when a list option gets focussed now the visual focus dashed border has been added for form select list options.
What was changed:
1 => Visual focus dashed border has been added for list options.
2 => Added focus border for both input field and dropdown icon for
terra-form-select.Why it was changed:
Terra Form select has a visual focus border however this focus border is not extended to the whole control i.e dropdown icon.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9837
Thank you for contributing to Terra.
@cerner/terra
Before fix :
After fix :
