This repository has been archived by the owner on May 24, 2024. It is now read-only.
[Terra-SearchSelect] Included the "Invalid" property in the example of an invalid case and set it to true. #3972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 15, 2023 09:54
sdadn
reviewed
Nov 15, 2023
| @@ -1,6 +1,8 @@ | |||
| # Changelog | |||
|
|
|||
| ## Unreleased | |||
| * Added | |||
| * Added 'aria-invalid' attribute to set to true for error input fields and false when resolving errors. | |||
There was a problem hiding this comment.
Suggested change
| * Added 'aria-invalid' attribute to set to true for error input fields and false when resolving errors. | |
| * Added 'aria-invalid' attribute which will be set to true for error input fields and false when resolving errors. |
added 2 commits
November 16, 2023 09:06
…6586-Terra-SearchSelect
sugan2416
approved these changes
Nov 16, 2023
supreethmr
reviewed
Nov 16, 2023
Comment on lines
+4
to
+5
| * Added | ||
| * Added visual label and associated with input field using 'for' and 'id'. |
There was a problem hiding this comment.
Suggested change
| * Added | |
| * Added visual label and associated with input field using 'for' and 'id'. | |
| * Added | |
| * Added visual label and associated with input field using 'for' and 'id'. |
Need a line break to keep it consistent with other logs
added 2 commits
November 16, 2023 15:28
supreethmr
approved these changes
Nov 16, 2023
…6586-Terra-SearchSelect
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed - Set the aria-invalid attribute to true for error input fields and false when resolving errors.
What was changed:
Included the "Invalid" property in the example of an invalid case and set it to true.
Introduced relevant visual label for search select example.
Why it was changed:
To declare as "Invalid" through the screen reader, indicating a field error.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9848
UXPLATFORM-9840
Thank you for contributing to Terra.
@cerner/terra