This repository has been archived by the owner on May 24, 2024. It is now read-only.
[Terra-Button-Group] Button group A11y Updates #3731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR Includes code changes for terra-button and terra-button-group to support Meaningful and decorative icon.
Changes of PR #3671 and PR #3679 has been included in this PR which Fixes keyboard focus and conveys selection state for screen readers.
Closes # [UXPLATFORM-8177]
Deployment Link
https://terra-core-deployed-pr-#.herokuapp.com/
Testing
Tested with VO and Jaws.
Tested with Jest and WDIO
Additional Details
Thank you for contributing to Terra.
@cerner/terra