This repository has been archived by the owner on May 24, 2024. It is now read-only.
[Terra-Icon] Removed Array from Icon Base #3717
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Array used to concat title tag with svg was causing below warnings. these warnings were causing jest test failures on one of consuming project.
js Warning: Each child in a list should have a unique "key" prop. Check the render method of `IconBase`. See https://fb.me/react-warning-keys for more information.
Consuming project has below config which will make jest to fail for console warnings / errors.
Closes UXPLATFORM-8297
Deployment Link
https://terra-core-deployed-pr-#.herokuapp.com/
Testing
no warnings / errors on browser console. verified on project which had jest failures
Additional Details
Thank you for contributing to Terra.
@cerner/terra