This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-hyperlink] Implement Accessibility changes (Part-1) #3605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supreethmr
reviewed
Apr 7, 2022
xenoworf
reviewed
Apr 7, 2022
packages/terra-core-docs/src/terra-dev-site/doc/hyperlink/UpgradeGuide.2.doc.mdx
Show resolved
Hide resolved
xenoworf
reviewed
Apr 7, 2022
xenoworf
reviewed
Apr 7, 2022
…into hyperlink-a11y
benbcai
reviewed
Apr 8, 2022
packages/terra-core-docs/src/terra-dev-site/doc/hyperlink/UpgradeGuide.2.doc.mdx
Outdated
Show resolved
Hide resolved
benbcai
reviewed
Apr 8, 2022
benbcai
reviewed
Apr 8, 2022
|
Is there a tech design for this story? |
ShettyAkarsh
approved these changes
Apr 11, 2022
supreethmr
approved these changes
Apr 11, 2022
sdadn
pushed a commit
that referenced
this pull request
May 11, 2022
* Pilot * Docs * Comments * Remove Badge * Minor Changes
sdadn
pushed a commit
that referenced
this pull request
May 11, 2022
* Pilot * Docs * Comments * Remove Badge * Minor Changes
sdadn
pushed a commit
that referenced
this pull request
Sep 30, 2022
* Pilot * Docs * Comments * Remove Badge * Minor Changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Marked isUnderlineHidden and isDisabled props as private. Markup changes for Disabled Hyperlink for better accessibility. Replaced children with text prop.
Closes #
Deployment Link
https://terra-core-deployed-pr-#.herokuapp.com/
Testing
Additional Details
Thank you for contributing to Terra.
@cerner/terra