This repository has been archived by the owner on May 24, 2024. It is now read-only.
Added Accessibility Guide For Terra-Image #3592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbcai
reviewed
Mar 3, 2022
packages/terra-core-docs/src/terra-dev-site/doc/image/AccessibilityGuide.3.doc.mdx
Outdated
Show resolved
Hide resolved
benbcai
reviewed
Mar 3, 2022
packages/terra-core-docs/src/terra-dev-site/doc/image/AccessibilityGuide.3.doc.mdx
Outdated
Show resolved
Hide resolved
benbcai
reviewed
Mar 3, 2022
packages/terra-core-docs/src/terra-dev-site/doc/image/AccessibilityGuide.3.doc.mdx
Outdated
Show resolved
Hide resolved
benbcai
reviewed
Mar 3, 2022
packages/terra-core-docs/src/terra-dev-site/doc/image/AccessibilityGuide.3.doc.mdx
Outdated
Show resolved
Hide resolved
benbcai
reviewed
Mar 3, 2022
packages/terra-core-docs/src/terra-dev-site/doc/image/AccessibilityGuide.3.doc.mdx
Outdated
Show resolved
Hide resolved
benbcai
reviewed
Mar 3, 2022
packages/terra-core-docs/src/terra-dev-site/doc/image/AccessibilityGuide.3.doc.mdx
Outdated
Show resolved
Hide resolved
|
@neilpfeiffer just explained that this PR is quite early in the process, so I'll hold off on further suggestions around grammar/language/formatting. In general this looks fine to me. When it is time to review further I'll be happy to do so. Carry on! PS: you can ignore my comments thus far since they were all assuming you wanted that level of review. |
* Update CODEOWNERS (#3579) * Add core-docs whitespace layout-helper (#3593) * Updated broken links in terra-form-select docs. (#3594) * Added Accessiblity Guide For Terra-Image * typo corrections * reveiw comment update * Accessibility Guide content updates * Updating A11Y Guide examples and adding new creative-commons images Co-authored-by: Elliott Hoffman <52507228+xenoworf@users.noreply.github.com> Co-authored-by: Ben Cai <benbcai@gmail.com> Co-authored-by: Supreeth MR <supreeth.mr1990@gmail.com>
|
New changes have been applied and look great. |
neilpfeiffer
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
Tested: PR #3592
Reviewed:
-
Adds new accessibility guide for Terra Image with sections indicating proper usage for:
- Why it is important
- Code Considerations
- Content Considerations
- Usability Expectations and Interaction Details
- Support Compliance
- Linked References
-
Contained examples and explanations for:
- Informative Images
- Decorative Images
Verified by @neilpfeiffer
| UX Reviewed |
|---|
sdadn
pushed a commit
that referenced
this pull request
May 11, 2022
* Update CODEOWNERS (#3579) * Added Accessiblity Guide For Terra-Image * typo corrections * Add core-docs whitespace layout-helper (#3593) * Updated broken links in terra-form-select docs. (#3594) * reveiw comment update * Added Accessiblity Guide For Terra-Image * typo corrections * reveiw comment update * Terra-Image accessibility guide edits (#3597) * Update CODEOWNERS (#3579) * Add core-docs whitespace layout-helper (#3593) * Updated broken links in terra-form-select docs. (#3594) * Added Accessiblity Guide For Terra-Image * typo corrections * reveiw comment update * Accessibility Guide content updates * Updating A11Y Guide examples and adding new creative-commons images Co-authored-by: Elliott Hoffman <52507228+xenoworf@users.noreply.github.com> Co-authored-by: Ben Cai <benbcai@gmail.com> Co-authored-by: Supreeth MR <supreeth.mr1990@gmail.com> Co-authored-by: Elliott Hoffman <52507228+xenoworf@users.noreply.github.com> Co-authored-by: Neil Pfeiffer <neil.pfeiffer@cerner.com> Co-authored-by: Ben Cai <benbcai@gmail.com>
sdadn
pushed a commit
that referenced
this pull request
May 11, 2022
* Update CODEOWNERS (#3579) * Added Accessiblity Guide For Terra-Image * typo corrections * Add core-docs whitespace layout-helper (#3593) * Updated broken links in terra-form-select docs. (#3594) * reveiw comment update * Added Accessiblity Guide For Terra-Image * typo corrections * reveiw comment update * Terra-Image accessibility guide edits (#3597) * Update CODEOWNERS (#3579) * Add core-docs whitespace layout-helper (#3593) * Updated broken links in terra-form-select docs. (#3594) * Added Accessiblity Guide For Terra-Image * typo corrections * reveiw comment update * Accessibility Guide content updates * Updating A11Y Guide examples and adding new creative-commons images Co-authored-by: Elliott Hoffman <52507228+xenoworf@users.noreply.github.com> Co-authored-by: Ben Cai <benbcai@gmail.com> Co-authored-by: Supreeth MR <supreeth.mr1990@gmail.com> Co-authored-by: Elliott Hoffman <52507228+xenoworf@users.noreply.github.com> Co-authored-by: Neil Pfeiffer <neil.pfeiffer@cerner.com> Co-authored-by: Ben Cai <benbcai@gmail.com>
sdadn
pushed a commit
that referenced
this pull request
Sep 30, 2022
* Update CODEOWNERS (#3579) * Added Accessiblity Guide For Terra-Image * typo corrections * Add core-docs whitespace layout-helper (#3593) * Updated broken links in terra-form-select docs. (#3594) * reveiw comment update * Added Accessiblity Guide For Terra-Image * typo corrections * reveiw comment update * Terra-Image accessibility guide edits (#3597) * Update CODEOWNERS (#3579) * Add core-docs whitespace layout-helper (#3593) * Updated broken links in terra-form-select docs. (#3594) * Added Accessiblity Guide For Terra-Image * typo corrections * reveiw comment update * Accessibility Guide content updates * Updating A11Y Guide examples and adding new creative-commons images Co-authored-by: Elliott Hoffman <52507228+xenoworf@users.noreply.github.com> Co-authored-by: Ben Cai <benbcai@gmail.com> Co-authored-by: Supreeth MR <supreeth.mr1990@gmail.com> Co-authored-by: Elliott Hoffman <52507228+xenoworf@users.noreply.github.com> Co-authored-by: Neil Pfeiffer <neil.pfeiffer@cerner.com> Co-authored-by: Ben Cai <benbcai@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added Accessibility guide for Terra-Image to provide overview of accessibility features that are provided by terra-image.
Closes #
Deployment Link
https://terra-core-img-accessib-zz4fks.herokuapp.com/components/cerner-terra-core-docs/image/accessibility-guide
Testing
Additional Details
Thank you for contributing to Terra.
@cerner/terra