This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-paginator] Add support for unknown total page count in the progressive paginator #3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@supreethmr not a part of this issue but can you remove terra-form-input from the dependencies. As I don't see it being used anywhere in the paginator. |
mjhenkes
reviewed
Nov 9, 2020
mjhenkes
reviewed
Nov 9, 2020
mjhenkes
reviewed
Nov 9, 2020
mjhenkes
approved these changes
Nov 9, 2020
|
Functional review complete. No issues identified. |
jeremyfuksa
approved these changes
Nov 12, 2020
ryanthemanuel
suggested changes
Nov 13, 2020
updated : 22baadd |
ryanthemanuel
approved these changes
Nov 17, 2020
saket2403
reviewed
Nov 18, 2020
| Terra.it.validatesElement(); | ||
| it('default', () => { | ||
| browser.url('/raw/tests/terra-paginator/paginator/paginator'); | ||
| Terra.validates.element(); |
There was a problem hiding this comment.
Can you give names for all the new screenshots (wherever missing), as name will be a required argument in WDIO-6.
There was a problem hiding this comment.
Let's hold off on this for now as this PR is old and I'd like to get it in at this point. If we want, we could do this on a separate PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes progressive paginator to support unknown page count similar to paginator component.
Closes #3157
Deployment Link
https://terra-core-paginator-wo-irwd3s.herokuapp.com/components/terra-paginator/paginator/progressive-paginator#examples
https://terra-core-paginator-wo-irwd3s.herokuapp.com/tests/terra-paginator/paginator/progressive-paginator-without-total-count
Testing
Tested through WDIO and Jest Tests
Additional Details
Thank you for contributing to Terra.
@cerner/terra