This repository has been archived by the owner on May 24, 2024. It is now read-only.
Added isBlock prop to Switch. #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilyrohrbough
approved these changes
Aug 7, 2020
jeremyfuksa
approved these changes
Aug 10, 2020
saket2403
approved these changes
Aug 11, 2020
ShettyAkarsh
approved these changes
Aug 11, 2020
mjhenkes
approved these changes
Aug 11, 2020
lokesh-0813
approved these changes
Aug 13, 2020
pranav300
approved these changes
Aug 13, 2020
|
Functional review complete. No issues identified. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To enable users to render switch as block element when required
isBlockstyle prop has been added.Closes #3113
Deployment Link
https://terra-core-is-block-swi-furvnm.herokuapp.com/components/terra-switch/switch/switch 🚀
Testing
Added WDIO and jest tests to validate new prop changes
Thank you for contributing to Terra.
@cerner/terra