Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Commit

Permalink
Fixes terra-ui build issue (#3764)
Browse files Browse the repository at this point in the history
Co-authored-by: SM051274 <sm051274@cerner.net>
  • Loading branch information
supreethmr and SM051274 authored Apr 6, 2023
1 parent 730f183 commit 9efacfc
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 8 deletions.
9 changes: 7 additions & 2 deletions packages/terra-core-docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

* Fixed
* Fixed `terra-ui` build failures happening due to usage of relative paths on mdx file.
* Fixed `terra-button` A11y guide example to match the description.

## 1.24.0 - (April 5, 2023)

* Added
Expand All @@ -10,11 +14,11 @@
* Added
* Added accessibility guide for `terra-hyperlink`
* Added Accessibility guideline for `terra-heading`
* Added examples for for `terra-list`
* Added examples for `terra-list`
* Added Accessibility Guide for `terra-section-header`
* Added accessibility guide for `terra-progress-bar`
* Added accessibility guide for `terra-avatar`
* Added examples for for `terra-alert`
* Added examples for `terra-alert`

* Changed
* Added tests for `terra-list`.
Expand All @@ -41,6 +45,7 @@

* Changed
* Updated radio and checkbox tests to fix fusion theme tests.

* Added
* Added Accessibility Guide for `terra-toggle`.
* Added A11y guide and examples for `terra-button`.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Badge } from 'terra-base/package.json?dev-site-package';

import ChangeLog from '../../../../CHANGELOG.md';
import ChangeLog from 'terra-base/CHANGELOG.md';

<Badge />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,13 @@ For buttons that use icons that do not convey a meaning, make sure they are mark
```jsx
import Button from 'terra-button';

<Button aria-label="Add Allergies" text="Add" className={cx('button')} />
<Button aria-label="Learn More About Allergies" text="Learn More" className={cx('button')} />
```
The screen reader user will hear something like: <samp> Add Allergies Button </samp>
The screen reader user will hear something like: <samp> Learn More About Allergies Button </samp>

![IMPORTANT](https://badgen.net/badge/UX/Accessibility/blue) The above example is NOT recommended. For Accessibility Best Practices it is recommended to use the same text for both visual and the programmatic label of the button.

Ensure any non-unique button label that is visually related to content in the page must be programmatically associated with its content. For example, a “Add” button next to the word “allergies” must be appropriate associated with the word allergies.
Ensure any non-unique button label that is visually related to content in the page must be programmatically associated with its content. For example, a “Learn more” button next to the word “allergies” must be appropriate associated with the word allergies.

</Notice>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const A11yButtonLabel = () => (
atopic dermatitis, allergic asthma, and anaphylaxis. Symptoms may include red eyes, an itchy rash, sneezing,
coughing, a runny nose, shortness of breath, or swelling.
</p>
<Button aria-label="Learn More About Allergies" href="https://en.wikipedia.org/wiki/Allergy" text="Learn More" className={cx('button')} />
<Button aria-label="Learn More About Allergies" text="Learn More" className={cx('button')} />
</Card.Body>
</Card>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import styles from './ButtonDocCommon.module.scss';
const cx = classNames.bind(styles);

const ButtonAnchor = () => (
<Button href="#" text="I am rendered with an anchor tag" className={cx('button')} />
<Button href="https://en.wikipedia.org/wiki/Allergy" text="Learn More about Allergies" className={cx('button')} />
);

export default ButtonAnchor;

0 comments on commit 9efacfc

Please sign in to comment.