Added a new function to calculate nth fibonacci number using golden r… #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atio, Closes:cereja-project#221 Signed-off-by: Mukul Bindal <mukulbinndal170299@gmail.com>
|
@jlsneto Kindly review these changes. |
jlsneto
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Hey! Thanks a lot for your contribution! I think it's already great, and it could be even better if you could add some documentation and perform a value check for the function parameter val. I know we all sometimes overlook these things (I've done it myself, as you can see in the module 😅). But it would be awesome if we could improve this together!
Signed-off-by: Mukul Bindal <mukulbinndal170299@gmail.com>
|
Hi @jlsneto I have added the requested changes, kindly review. Post this I will work on test case restructure!! |
jlsneto
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…atio, Closes:#221