Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox,travis: test on Python 3.8 instead of 3.7 #338

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

smithfarm
Copy link
Contributor

And for local testing we can get away with 3.6 only. (It's convenient to
be able to run "tox" and not get all tests repeated in 3.8 after they
all ran once in 3.6.)

Fixes: #336
Signed-off-by: Nathan Cutler ncutler@suse.com

@smithfarm smithfarm added tests PR makes changes to tests, or adds new tests cleanup labels Aug 24, 2020
@ricardoasmarques
Copy link
Contributor

Relates to #148

And for local testing we can get away with 3.6 only. (It's convenient to
be able to run "tox" and not get all tests repeated in 3.8 after they
all ran once in 3.6.)

Fixes: ceph#336
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
Copy link
Contributor Author

I think this PR could be seen as being "the fix" for #148. (At least, it proves that #148 has been fixed in the meantime.)

@ricardoasmarques ricardoasmarques added the Add To Changelog Marks the PR to be included in the changelog of the next version release label Aug 27, 2020
Copy link
Contributor

@ricardoasmarques ricardoasmarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ricardoasmarques ricardoasmarques merged commit 55238f3 into ceph:master Aug 27, 2020
@ricardoasmarques ricardoasmarques removed the Add To Changelog Marks the PR to be included in the changelog of the next version release label Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup tests PR makes changes to tests, or adds new tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.8 has been released, so Travis should test against it instead of 3.7
2 participants