Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Substrate 2.0.0-RC6 #97

Merged
merged 9 commits into from
Sep 25, 2020
Merged

Conversation

mikiquantum
Copy link
Contributor

@mikiquantum mikiquantum commented Sep 24, 2020

Updates:

  • Go Version to 1.14.x
  • Events
  • TransactionVersion in Signature
  • Weight to u64
  • Use of Substrate RC6 image
  • Latest subkey 2.0.0

@mikiquantum mikiquantum changed the title Update to Substrate 2.0.0-RC6 WIP - Update to Substrate 2.0.0-RC6 Sep 24, 2020
This was referenced Sep 24, 2020
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #97 into master will decrease coverage by 2.72%.
The diff coverage is 75.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   60.36%   57.63%   -2.73%     
==========================================
  Files          90       92       +2     
  Lines        3658     3118     -540     
==========================================
- Hits         2208     1797     -411     
+ Misses       1094      964     -130     
- Partials      356      357       +1     
Impacted Files Coverage Δ
types/event_record.go 57.54% <ø> (-1.08%) ⬇️
types/runtime_version.go 32.25% <ø> (-2.53%) ⬇️
types/weight.go 100.00% <ø> (ø)
types/extrinsic_payload.go 22.03% <41.93%> (-26.36%) ⬇️
signature/signature.go 60.93% <100.00%> (-0.83%) ⬇️
types/balance_status.go 100.00% <100.00%> (ø)
types/election_compute.go 100.00% <100.00%> (ø)
types/events.go 85.10% <100.00%> (+3.28%) ⬆️
types/extrinsic.go 48.12% <100.00%> (-2.92%) ⬇️
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5b9dc6...16d474b. Read the comment docs.

@mikiquantum mikiquantum removed the WIP label Sep 24, 2020
@mikiquantum mikiquantum changed the title WIP - Update to Substrate 2.0.0-RC6 Update to Substrate 2.0.0-RC6 Sep 24, 2020
@@ -2,11 +2,11 @@
# preventing them from being used to build Substrate/Polkadot.

# First Phase - Load Subkey
FROM parity/subkey:2.0.0-alpha.3 as subkey
FROM parity/subkey:2.0.0 as subkey
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version v2.0.0-rc6 for subkey is broken, so opted to use 2.0.0 instead.

Copy link
Contributor

@vedhavyas vedhavyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks!
LGTM

@mikiquantum mikiquantum merged commit fee0d0e into centrifuge:master Sep 25, 2020
@mikiquantum mikiquantum deleted the feat/rc6 branch September 25, 2020 14:14
robdefeo added a commit to mailchain/go-substrate-rpc-client that referenced this pull request Sep 26, 2020
@lucasvo
Copy link
Member

lucasvo commented Sep 28, 2020

I think this fixes the public key issue in #83 and #80 correct? Could you close them @mikiquantum ?

@mikiquantum
Copy link
Contributor Author

@lucasvo nope, #80 is not addressed yet, because I believe we should tackle #83 instead., which will implicitly #80 as the response would be a structured json, easily indexable instead of parsing a text output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants