Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt: wrap comments #1330

Merged
merged 5 commits into from
May 4, 2023
Merged

fmt: wrap comments #1330

merged 5 commits into from
May 4, 2023

Conversation

wischli
Copy link
Contributor

@wischli wischli commented May 2, 2023

Description

  • Adds and applies comment wrapping to format config
  • Based on discussion in DAO Slack

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

NunoAlexandre
NunoAlexandre reviewed May 2, 2023
View reviewed changes
Copy link
Contributor

@NunoAlexandre NunoAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just caught one weird spacing issue, the rest looks good!

libs/test-utils/src/mocks/order_manager.rs Outdated Show resolved Hide resolved
@wischli @NunoAlexandre
Update libs/test-utils/src/mocks/order_manager.rs
129e57f 
Co-authored-by: Nuno Alexandre <hi@nunoalexandre.com>
@wischli wischli requested a review from NunoAlexandre May 2, 2023 14:11
NunoAlexandre
NunoAlexandre previously approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@NunoAlexandre NunoAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❇️

lemunozm
lemunozm previously approved these changes May 3, 2023
View reviewed changes
mustermeiszer
mustermeiszer previously approved these changes May 3, 2023
View reviewed changes
@wischli wischli dismissed stale reviews from mustermeiszer, lemunozm, and NunoAlexandre via 0923617 May 3, 2023 18:35
@lemunozm
Copy link
Contributor

lemunozm commented May 3, 2023

Do we have any way to ensure this is correct for new PRs in CI? (maybe in our docs job)

@wischli
Copy link
Contributor Author

wischli commented May 4, 2023

Do we have any way to ensure this is correct for new PRs in CI? (maybe in our docs job)

Yes! The new rule is applied to our linting CI check cargo fmt -- --check. That's why the CI failed yesterday after just merging main without re-running cargo fmt.

mustermeiszer
mustermeiszer approved these changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@mustermeiszer mustermeiszer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve

@wischli wischli merged commit 189b221 into main May 4, 2023
@lemunozm lemunozm deleted the fmt/wrap-comments branch May 4, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustermeiszer mustermeiszer mustermeiszer approved these changes

@lemunozm lemunozm lemunozm approved these changes

@mikiquantum mikiquantum Awaiting requested review from mikiquantum

@branan branan Awaiting requested review from branan

@NunoAlexandre NunoAlexandre Awaiting requested review from NunoAlexandre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wischli @lemunozm @NunoAlexandre @mustermeiszer