feat(tinlake-ui): update pool title, fix wording #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 17, 2020
philipstanislaus
approved these changes
Dec 18, 2020
| @@ -208,7 +208,7 @@ const TrancheOverview: React.FC<Props> = (props: Props) => { | |||
| {card === 'redeem' && <RedeemCard {...props} setCard={setCard} updateTrancheData={updateTrancheData} />} | |||
|
|
|||
| {trancheData?.token && trancheData.token.length > 0 && trancheData.token.length < 7 && ( | |||
| <AddWalletLink onClick={addToWallet}>Add {trancheData?.token} to your wallet</AddWalletLink> | |||
| <AddWalletLink onClick={addToWallet}>Display {trancheData?.token} in your wallet</AddWalletLink> | |||
There was a problem hiding this comment.
I'm not sure Display is clearer. Can we be a bit more wordy?
Maybe Add this token to your Metamask wallet.
There was a problem hiding this comment.
That's from Dennis's issue: #69. We should avoid the word "add" at least, since it implies "getting" the token. Whereas "display" avoids this connotation.
There was a problem hiding this comment.
I also think it's good to mention the actual token symbol in the text.
There was a problem hiding this comment.
I find that highly confusing since it’s not displayed anywhere else. But sure, we can improve that another time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.