Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add underlines to tooltips #312

Merged
merged 12 commits into from
Aug 9, 2021
Merged

add underlines to tooltips #312

merged 12 commits into from
Aug 9, 2021

Conversation

onnovisser
Copy link
Collaborator

Adds underlines to most tooltips.

image

image

Closes #289

@onnovisser onnovisser requested a review from jpangelle August 3, 2021 14:11
@github-actions
Copy link

github-actions bot commented Aug 4, 2021

🚀 Deployed on https://pr-312--dev-tinlake.netlify.app

Comment on lines 37 to 45
let title
let link
let description

if ('id' in props) {
;({ title, link, description } = tooltips[props.id] as Tooltip)
} else {
;({ title, link, description } = props)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated 😏

Copy link
Contributor

@jpangelle jpangelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@onnovisser onnovisser merged commit e9eb866 into main Aug 9, 2021
@onnovisser onnovisser deleted the tooltip-underline branch August 9, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add visual clue to content elements bearing a tooltip
2 participants