Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly update ui on closing epoch flow #260

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Conversation

jpangelle
Copy link
Contributor

@jpangelle jpangelle commented Jun 22, 2021

Description

  • Adds more dependencies to the useEffect that executes the loadPool thunk in order to refetch the pool when changes to the epoch flow are made
  • Adds another case to the EpochButton component to show a disabled Close epoch button for when an epoch is open

Two caveats:

  1. Sometimes it can take absurdly long to eventually rerender to the proper view like (5-10 seconds)
  2. For the flow where closing the epoch is automatically executed, the UI does not properly rerender once the 5 minutes pass to go from Lock DAI -> Epoch Executed.

Closes #235

@jpangelle jpangelle requested review from hieronx and denniswell June 22, 2021 03:26
@github-actions
Copy link

github-actions bot commented Jun 22, 2021

🚀 Deployed on https://pr-260--dev-tinlake.netlify.app

@hieronx hieronx merged commit 3f944ef into main Jul 16, 2021
@hieronx hieronx deleted the update-ui-epoch branch July 16, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove/Update Close epoch implementation
2 participants