Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTOR-102 [(New tests): network::cyberoam::snmp] #5335

Conversation

sfarouq-ext
Copy link
Contributor

Community contributors

Description

TEST CREATED
tests/network/cyberoam/snmp/ha-status.robot
-interfaces.robot
-license.robot
-list-interfaces.robot
-list-vpns.robot
-memory.robot
-requests.robot
-services.robot
-storage.robot
-vpn-status.robot

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

If some information is confidential, such as logins or IP addresses, obfuscate them in what is sent
publicly and we'll get in touch with you by private message if this information is needed.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • I have provide data or shown output displaying the result of this code in the plugin area concerned.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched.
Provide clear instructions so that it can be correctly tested.
Mention the automated tests included in this FOR (what they test like mode/option combinations).

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • In case of a new plugin, I have created the new packaging directory accordingly.
  • I have implemented automated tests related to my commits.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences are terminated by a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

@omercier omercier self-requested a review January 17, 2025 10:22
@lucie-dubrunfaut lucie-dubrunfaut added the internal Centreon internal PR label Jan 20, 2025
@Evan-Adam Evan-Adam force-pushed the CTOR-102-plugin-network-cyberoam-snmp-sophos-xgs-firewall-add-mode-for-ha-vpn-and-license branch from a8c9f96 to c286fee Compare January 27, 2025 14:47
@Evan-Adam Evan-Adam merged commit 9007170 into develop Jan 27, 2025
13 of 14 checks passed
@Evan-Adam Evan-Adam deleted the CTOR-102-plugin-network-cyberoam-snmp-sophos-xgs-firewall-add-mode-for-ha-vpn-and-license branch January 27, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants