-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTOR-102 [(New tests): network::cyberoam::snmp] #5335
Merged
Evan-Adam
merged 20 commits into
develop
from
CTOR-102-plugin-network-cyberoam-snmp-sophos-xgs-firewall-add-mode-for-ha-vpn-and-license
Jan 27, 2025
Merged
CTOR-102 [(New tests): network::cyberoam::snmp] #5335
Evan-Adam
merged 20 commits into
develop
from
CTOR-102-plugin-network-cyberoam-snmp-sophos-xgs-firewall-add-mode-for-ha-vpn-and-license
Jan 27, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48022b6
to
54f0cc0
Compare
omercier
reviewed
Dec 16, 2024
omercier
reviewed
Dec 16, 2024
omercier
reviewed
Dec 16, 2024
omercier
reviewed
Dec 16, 2024
omercier
reviewed
Dec 16, 2024
omercier
approved these changes
Jan 17, 2025
Evan-Adam
approved these changes
Jan 27, 2025
- fix copy-pasted tests - enhanced coding style - made the help about expiration a little more explicit
- added bits from the MIB to explain the code - improved the tests to make them more complete
a8c9f96
to
c286fee
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community contributors
Description
TEST CREATED
tests/network/cyberoam/snmp/ha-status.robot
-interfaces.robot
-license.robot
-list-interfaces.robot
-list-vpns.robot
-memory.robot
-requests.robot
-services.robot
-storage.robot
-vpn-status.robot
Type of change
If some information is confidential, such as logins or IP addresses, obfuscate them in what is sent
publicly and we'll get in touch with you by private message if this information is needed.
Checklist
Type of change
How this pull request can be tested ?
Please describe the procedure to verify that the goal of the PR is matched.
Provide clear instructions so that it can be correctly tested.
Mention the automated tests included in this FOR (what they test like mode/option combinations).
Checklist