Support the use of a regexp to filter interface IDs #4956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
- added tests for filtering on ids list - added tests for filtering on ids by regex - the first one worked only with the code prior to this PR - the second worked only with Yanis' branch - added a new option to toggle the behaviour and used it to make all tests pass
- pycharm removed EOL spaces - added some stopwords - added some comments
3961cfb to
3864bb6
Compare
sdepassio
approved these changes
Mar 25, 2024
omercier
added a commit
that referenced
this pull request
May 28, 2024
Co-authored-by: �ykacherCentreon <ykacher@centreon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Could not be pushed to MON-34949-plugin-allow-regex-when-using-interface-only (#4876) after rebasing with develop, so I create this PR with this branch
Type of change