Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTOR-305 [Plugin] [CommunityPR] New link-monitor mode on Fortinet Fortigate #4882

Conversation

lucie-dubrunfaut
Copy link
Contributor

Description

Development from C.Gagnaire 4639

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

@kduret
Copy link
Contributor

kduret commented Feb 5, 2024

Next Time, cherry pick the commit of the fork to keep original author

@lucie-dubrunfaut lucie-dubrunfaut merged commit 68a17c7 into develop Feb 12, 2024
14 checks passed
@lucie-dubrunfaut lucie-dubrunfaut deleted the CTOR-305-community-pr-new-link-monitor-mode-on-fortinet-fortigate branch February 12, 2024 07:58
@cgagnaire
Copy link
Contributor

Hi @lucie-dubrunfaut,
Just for the record, I'm noticing the change of behaviour in the way the requests are made.
In my commit I request the list of link monitors name before applying the filter and then request for the statistics on selected links.
This way, less data is retrieved.
I think this should be something to put forward globally to reduce execution and network footprint.

@lucie-dubrunfaut
Copy link
Contributor Author

Hmm I understand better now why you chose to use two loops, it shouldn't take too much change to get this behavior back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants