Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable creation of AttackObject in Django admin #165

Merged
merged 1 commit into from
May 4, 2022

Conversation

mehaase
Copy link
Contributor

@mehaase mehaase commented Mar 18, 2022

Not sure why these fields were marked as readonly, but it prevents any meaningful usage of the AttackObject admin UI. Opening this PR as a draft so I can get some feedback on whether this breaks anything else. (Fixes #163)

@mehaase mehaase changed the title Draft: Enable creation of AttackObject in Django admin (fix #163) Draft: Enable creation of AttackObject in Django admin Mar 18, 2022
@mehaase mehaase marked this pull request as draft March 18, 2022 15:35
Also rename DEBUG -> DJANGO_DEBUG, which is a little bit safer/less
likely to collide with some other env var.
@mehaase mehaase force-pushed the 164-add-new-attack-object branch from 535db9e to 3f77439 Compare March 18, 2022 15:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #165 (3f77439) into master (7c9d875) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   95.63%   95.63%           
=======================================
  Files           9        9           
  Lines         847      847           
=======================================
  Hits          810      810           
  Misses         37       37           
Impacted Files Coverage Δ
src/tram/admin.py 100.00% <100.00%> (ø)
src/tram/report/docx.py 98.52% <0.00%> (-1.48%) ⬇️
src/tram/ml/base.py 91.60% <0.00%> (-0.41%) ⬇️
src/tram/views.py 94.57% <0.00%> (+1.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c9d875...3f77439. Read the comment docs.

@Wojak394
Copy link

It works and I had no errors. Thanks :)

@mehaase mehaase marked this pull request as ready for review March 30, 2022 13:15
@mehaase mehaase changed the title Draft: Enable creation of AttackObject in Django admin Enable creation of AttackObject in Django admin Mar 30, 2022
@mehaase mehaase requested a review from m3mike March 30, 2022 13:15
@mehaase mehaase requested a review from dvoegeli April 15, 2022 15:06
@mehaase mehaase merged commit e7ddfe0 into master May 4, 2022
@mehaase mehaase deleted the 164-add-new-attack-object branch May 4, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to add new attack object
2 participants