Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): reformat codebase using pre-commit #140

Merged
merged 3 commits into from
Feb 8, 2022

Conversation

m3mike
Copy link
Contributor

@m3mike m3mike commented Feb 7, 2022

What Changed

  • Reformatted codebase using pre-commit configuration (isort/black)
  • Added some exclusions to pre-commit for data, migration files, minified files, etc

Limitations
n/a

@m3mike m3mike requested review from emmanvg and mehaase February 7, 2022 21:22
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #140 (44c600a) into master (3ddf69a) will not change coverage.
The diff coverage is 93.61%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   94.56%   94.56%           
=======================================
  Files          20       20           
  Lines         828      828           
=======================================
  Hits          783      783           
  Misses         45       45           
Impacted Files Coverage Δ
src/tram/manage.py 0.00% <0.00%> (ø)
src/tram/tram/serializers.py 95.16% <84.84%> (ø)
src/tram/tram/views.py 94.84% <88.00%> (ø)
src/tram/tram/ml/base.py 92.88% <95.83%> (ø)
src/tram/tram/admin.py 100.00% <100.00%> (ø)
src/tram/tram/management/commands/attackdata.py 96.92% <100.00%> (ø)
src/tram/tram/management/commands/pipeline.py 100.00% <100.00%> (ø)
src/tram/tram/models.py 100.00% <100.00%> (ø)
src/tram/tram/urls.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ddf69a...44c600a. Read the comment docs.

@m3mike
Copy link
Contributor Author

m3mike commented Feb 7, 2022

@mehaase @emmanvg this PR reformats and is ready to go. The only CI failure is related to the diff coverage being lower than 94.5% (at 93.61%) which can be safely ignored.

Copy link
Contributor

@mehaase mehaase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround!

Copy link
Contributor

@emmanvg emmanvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for providing this 🥂

@emmanvg emmanvg merged commit 12cd95a into master Feb 8, 2022
@emmanvg emmanvg deleted the refactor/autolint_src_code branch February 8, 2022 01:26
@emmanvg emmanvg added this to the v1.1.2 milestone Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants