Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAPEX-167: Mapping File Search #19

Merged
merged 22 commits into from
Feb 6, 2024
Merged

MAPEX-167: Mapping File Search #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
dcc191c
install flexsearch
Feb 2, 2024
d9b3dac
build search index on file load
Feb 2, 2024
4e0081b
update index in reindex function
Feb 2, 2024
55aebfa
add search results to MappingFileSearch component
Feb 2, 2024
3ea46a5
remove log statement
Feb 2, 2024
83ee652
restructure functions
Feb 2, 2024
32a0b2b
remove readonly from search index
Feb 2, 2024
c8cbc65
account for empty search results
Feb 2, 2024
0cd72d4
remove buildsearchindex from editor
Feb 2, 2024
2af8b11
review changes
Feb 2, 2024
333a37f
fix comments
Feb 2, 2024
761c646
add comments and some fixes to MappingFileSearch
Feb 5, 2024
52b2eea
fix minor errors
Feb 5, 2024
05ae76f
add mappingObjectDocument type
Feb 5, 2024
814251f
search on every enter press; track current items correctly
Feb 5, 2024
c8b563d
add 'type' to import
Feb 5, 2024
462316a
fix type errors
Feb 5, 2024
5f04941
review changes
Feb 5, 2024
e4db266
use commands
Feb 5, 2024
49156a4
review changes
Feb 6, 2024
41c9e6e
refactor `MappingFileEditor` search behavior
mikecarenzo Feb 6, 2024
4c92588
refactor search behavior
mikecarenzo Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/mappings_editor/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/mappings_editor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"lint": "eslint . --ext .vue,.js,.jsx,.cjs,.mjs,.ts,.tsx,.cts,.mts --fix --ignore-path .gitignore"
},
"dependencies": {
"flexsearch": "^0.7.43",
"pinia": "^2.1.7",
"vue": "^3.3.4"
},
Expand Down
14 changes: 10 additions & 4 deletions src/mappings_editor/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,12 @@
/>
</div>
<div class="frame center">
<MappingFileSearch
id="file-search"
:editor="activeEditor"
/>
<div id="file-search">
<MappingFileSearch
:editor="activeEditor"
@execute="onExecute"
/>
</div>
<MappingFileViewControl
id="file-editor"
:editor="activeEditor"
Expand Down Expand Up @@ -296,8 +298,12 @@ ul {
}

#file-search {
display: flex;
align-items: center;
height: 90px;
width: 100%;
padding: 0px 40px;
box-sizing: border-box;
}

#file-editor {
Expand Down
2 changes: 0 additions & 2 deletions src/mappings_editor/src/assets/scripts/Application/Commands/FileManagement/LoadFile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ export class LoadFile extends AppCommand {
context.execute(new SaveFileToRecoveryBank(context, editor))
})
}


/**
* Executes the command.
*/
Expand Down
Loading
Loading