Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAPEX-161: Fix Export Inconsistencies #16

Merged
merged 4 commits into from
Feb 7, 2024
Merged

MAPEX-161: Fix Export Inconsistencies #16

merged 4 commits into from
Feb 7, 2024

Conversation

mikecarenzo
Copy link
Contributor

@mikecarenzo mikecarenzo commented Feb 1, 2024 •
edited
Loading

Fixes #161

What Changed

This PR fixes a series of export issues that keep save files from conforming with the schema:

  • Exported dates now have single-digit days and months prefixed with 0.
  • groups is renamed to capability_groups.
  • group is renamed to capability_group.
  • related_score is only exported when a sub-technique has an assigned score.

Known Limitations

None

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

This PR has been published to https://mappingseditor.z13.web.core.windows.net/MAPEX-161_fix_export_inconsistencies/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

This PR has been published to https://mappingseditor.z13.web.core.windows.net/MAPEX-161_fix_export_inconsistencies/

@mikecarenzo mikecarenzo requested a review from emeth1 February 7, 2024 01:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

This PR has been published to https://mappingseditor.z13.web.core.windows.net/MAPEX-161_fix_export_inconsistencies/

emeth1
emeth1 requested changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@emeth1 emeth1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a file with the unified data schema is opened and then saved, the capability_groups are empty, and the mapping object has no capability_group field.
Screenshot 2024-02-07 at 10 38 53 AM

@mikecarenzo mikecarenzo merged commit b5ff4ac into main Feb 7, 2024
2 checks passed
@mikecarenzo mikecarenzo deleted the MAPEX-161_fix_export_inconsistencies branch February 7, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emeth1 emeth1 emeth1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikecarenzo @emeth1