427 revoked objects should not be editable #433
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to revoked$; modify editable property to only be capable of resolving to true if revoked is false
…d to ensure that subscribers' copies of revoked are kept in sync
…rty is synchronized with the StixViewPage child component currently in view; modify editable property to only be capable of resolving to true when revoked is false
|
Kudos, SonarCloud Quality Gate passed!
|
TODO:Need to add a few things before this can be merged:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #427
Solution
We don't want object's to be editable if an object is revoked and/or when an object becomes revoked. Components that deal with rendering the editing toolbar must be updated to only render when
revokedis false.We can accomplish this with a shared service and a boolean observable called
revoked. STIX-based components can sync their nestedrevokedvalues (i.e.,this.config.object.revoked) to the shared service, and components that depend on therevokedvalue (i.e.,ToolbarComponent) can subscribe to the observable.