This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
User interaction example #83
Merged
draffensperger
merged 7 commits into
census-instrumentation:master
from
crdgonzalezca:react_example
May 22, 2019
Merged
User interaction example #83
draffensperger
merged 7 commits into
census-instrumentation:master
from
crdgonzalezca:react_example
May 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crdgonzalezca
requested review from
draffensperger,
johnbryan and
mayurkale22
as code owners
May 21, 2019 22:01
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
=======================================
Coverage 96.45% 96.45%
=======================================
Files 26 26
Lines 621 621
Branches 76 76
=======================================
Hits 599 599
Misses 22 22 Continue to review full report at Codecov.
|
draffensperger
suggested changes
May 22, 2019
}, (response) => { | ||
let data = []; | ||
response.on('data', chunk => data.push(chunk)); | ||
response.on('end', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would you think about making this a separate function to reduce the nesting of the code?
draffensperger
suggested changes
May 22, 2019
draffensperger
approved these changes
May 22, 2019
RenaultAI
pushed a commit
to RenaultAI/opencensus-web
that referenced
this pull request
Nov 20, 2019
Added zPages as the diagnostic helper for the overall ocagent process itself #inception By default the zPages run at ":55679/debug". They can be disabled in the config.yaml file by using the attribute `disabled` ```yaml zpages: disabled: true port: 8888 ``` Also added as an attribute the number of exported spans for every internal interceptor span. Fixes census-instrumentation#83
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example creates a client in ReactJS and a server in Node js. The client sends two network calls to the Node server, then the client does some calculations and renders the changes.