This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Default trace/span IDs to random in getInitialLoadRootSpan (with correct base now) #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-web into default-initial-load-ids
…-web into default-initial-load-ids
mayurkale22
approved these changes
Mar 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
getInitialLoadRootSpangenerate random trace/span IDs if none are given. This will help theopencensus-web-allpackage in cases when there is no trace/span ID sent back from the server via the config object on thewindow.This required exporting the
randomTraceIdandrandomSpanIdfunctions fromopencensus-core.This is the same as #19 but I forgot to change the base back to
masterafter it's dependent PR was merged.