This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Refactor out record long tasks into a separate function #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mayurkale22 ping on this for a review, thansk! |
mayurkale22
approved these changes
Mar 7, 2019
packages/opencensus-web-instrumentation-perf/src/long-tasks-recorder.ts
Outdated
Show resolved
Hide resolved
| navigationTiming?: PerformanceNavigationTimingExtended; | ||
| paintTimings: PerformancePaintTiming[]; | ||
| resourceTimings: PerformanceResourceTimingExtended[]; | ||
| longTasks: PerformanceLongTaskTiming[]; |
There was a problem hiding this comment.
s/longTasks/longTasksTimings ?
There was a problem hiding this comment.
Sure, changed to longTaskTimings.
RenaultAI
pushed a commit
to RenaultAI/opencensus-web
that referenced
this pull request
Nov 20, 2019
* Fix import path from gen-go files. * Update opencensus-proto in vendor directory. * Fix package name conflict.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors out the functionality to collect long task timings into a separate module that stores the timings on a
windowobject. That will be useful so that I can have the long task recording be in a JS bundle that should load right when the page starts, but have the rest of this code load asyncronously even after theloadevent fires.