This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Fix generation of tracing-all-with-zone bundle script
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
=========================================
- Coverage 96.01% 95.9% -0.11%
=========================================
Files 30 30
Lines 853 855 +2
Branches 147 148 +1
=========================================
+ Hits 819 820 +1
- Misses 34 35 +1
Continue to review full report at Codecov.
|
draffensperger
approved these changes
Aug 5, 2019
| @@ -64,5 +64,5 @@ | |||
| "@opencensus/web-instrumentation-zone-peer-dep": "^0.0.3", | |||
| "zone.js": "~0.9.1" | |||
| }, | |||
| "sideEffects": false | |||
| "sideEffects": true | |||
There was a problem hiding this comment.
Nice catch here! And a good reason for this to be a separate package from the -peer-dep one!
RenaultAI
pushed a commit
to RenaultAI/opencensus-web
that referenced
this pull request
Nov 20, 2019
As per the consensus from census-instrumentation#151, rename interceptor to receiver but also the related interfaces too and their methods. Fixes census-instrumentation#166
This was referenced Jan 24, 2020
This was referenced Feb 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
tracing-all-with-zone.jsbundle script to take theZone.jscode with it.