Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Add @opencensus/web-instrumentation-zone-peer-dep #147

Merged

Conversation

crdgonzalezca
Copy link
Contributor

Add this new package allow customers to choose a package with Zone.js as hard dependy or as peer dependency. This allows to applications in frameworks like React to avoid adding that dependency, also, for apps already depending on Zone.js this is not added, that is the case for Angular apps.

Copy link
Contributor

@draffensperger draffensperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened with the Zone.js type that was missing from their .d.ts file? How did that get resolved?

@crdgonzalezca
Copy link
Contributor Author

crdgonzalezca commented Jul 30, 2019

What happened with the Zone.js type that was missing from their .d.ts file? How did that get resolved?

This PR does not update the Zone.js library to the last version and the problem is related to that version. I am planning on doing this for a different PR as I consider this is big enough.

@codecov-io
Copy link

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #147   +/-   ##
======================================
  Coverage    95.9%   95.9%           
======================================
  Files          30      30           
  Lines         855     855           
  Branches      148     148           
======================================
  Hits          820     820           
  Misses         35      35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab8111...1e6f767. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants