Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Update gen-go files. #187

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Conversation

songy23
Copy link
Contributor

@songy23 songy23 commented Mar 13, 2019

No description provided.

@songy23 songy23 added this to the v0.2.0 release milestone Mar 13, 2019
@songy23
Copy link
Contributor Author

songy23 commented Mar 13, 2019

Apologies - need to run this first.

@songy23 songy23 merged commit ff7a782 into census-instrumentation:master Mar 13, 2019
@songy23 songy23 deleted the update-gen-go branch March 13, 2019 00:37
songy23 added a commit to songy23/instrumentation-proto that referenced this pull request Mar 13, 2019
songy23 added a commit that referenced this pull request Mar 13, 2019
(cherry picked from commit ff7a782)
@icco
Copy link

icco commented Mar 13, 2019

@songy23 not sure why, but this broke my builds:

../../../../pkg/mod/contrib.go.opencensus.io/exporter/stackdriver@v0.9.1/metrics.go:357:17: metric.GetName undefined (type *"github.com/census-instrumentation/opencensus-proto/gen-go/metrics/v1".Metric has no field or method GetName)

@songy23
Copy link
Contributor Author

songy23 commented Mar 13, 2019

@icco That's caused by #184 which removed the name field from metric, while opencensus-go-exporter-stackdriver used to depend on an unreleased version with that field. Filed census-ecosystem/opencensus-go-exporter-stackdriver#101 and I'll take a look at it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants