-
Notifications
You must be signed in to change notification settings - Fork 95
Conversation
@songy23 |
Why do we need Go proto build, given that we already have the gen-go files? |
We don't need this. bazel don't generate the final artifacts, that's why we use the protoc directly to generate those files. |
@yancl this is very nice. can you please give me some context why do you need this? Do you use bazel on your project and want to build using bazel everything? |
Thank you all for your review:) @bogdandrutu yes, we almost build everything using bazel. The problem is that we want to marshal the spans and send it to kafka through the ocagent. Then some jobs can consume the spans and make some analysis. But as you see, there isn't some proto already defined in the repo like the following that support this, so we need to define some proto that references the upstream trace proto and support Bazel build. So we think maybe the PR will be useful.
BTW, do you think give a PR like |
I think the "DumpSpan" should not live in this repo. Everything else looks great. |
@yancl please take a look at the already published https://godoc.org/github.com/census-instrumentation/opencensus-proto/gen-go/trace/v1 but also we provide functionality for uploading spans from OpenCensus-Go instrumented applications to ocagent in https://godoc.org/contrib.go.opencensus.io/exporter/ocagent#NewExporter |
@odeke-em thank you for your great information. Now we almost use the same mechanism you point, opencensus-go instrumented applications in each container export spans to the ocagent(https://github.com/census-instrumentation/opencensus-service) in the node through grpc, which then aggregates the spans and send them to kafka brokers. Then some jaeger collectors consume the spans from kafka and write them to jaeger backend in one way, some spark jobs consume the kafka for some extra analysis to fit our own needs in another way. So that's why we need to dump spans by pb format(support different kind of consumer of different languages). I found there are zipkin,jaeger,stackdriver and general collector exporter support in the opencensus-service, but no kafka exporter support. So maybe we could add a kafka support in the opencensus-service, is that suitable? Thanks. |
Cool, and that's what the opencensus-service is meant to support :)
For starters, if you've got the time commitment and can work on stuff, please publish the Kafka exporter and once it is up, we can talk about perhaps integrating in opencensus-service. Adding an exporter to opencensus-service is trivial :) How does that sound? If your Kafka exporter isn't open sourced and if you'd like to keep it closed source, unfortunately we currently don't have a method for dynamically loading external exporters but one can be made e.g. a "discard channel" exporter that just pumps out spans and allows for scraping from external providers. Great to hear that we already have a user that is seriously consuming the opencensus-service #moreMotivation |
Glad to hear that, we will open source the kafka exporter when it works fine. Thanks again for your great work!!! |
No description provided.