-
Notifications
You must be signed in to change notification settings - Fork 77
Pin external repositories in WORKSPACE #130
Comments
Abseil prefers to be built from head if possible: https://abseil.io/about/compatibility. However, I think we should pin repositories in at least two situations:
|
Users of OpenCensus can have reproducible builds by pinning in their (outermost) WORKSPACE. Abseil hasn't broken compatibility yet. gRPC has a couple of times, although moving the gRPC plugin to their repo will mitigate that somewhat in the future. Pinning, or at least having some sense of "opencensus-cpp release X works with grpc release Y", would be good, but I'd also like to avoid tons of commits to OpenCensus bumping the versions of dependencies and bazel. |
Any update on this? |
I'd like to keep the master branch building everything from HEAD. Once we start doing release branches, we could record our dependencies' versions at release time. Doing this doesn't really affect users of opencensus-cpp because it's their project's WORKSPACE file that specifies which version of every transitive dependency to use - this is bazel's approach to dependencies. |
- Add brief summary. - Add example PRs. - Add instructions on pinning build deps (fixes census-instrumentation#130). - Add CMake instructions. - Use the releases page to create the tag based on a verified commit.
- Add brief summary. - Add example PRs. - Add instructions on pinning build deps (fixes #130). - Add CMake instructions. - Use the releases page to create the tag based on a verified commit.
External repositories are now pinned for OpenCensus releases. Closing this issue. |
- Add brief summary. - Add example PRs. - Add instructions on pinning build deps (fixes census-instrumentation#130). - Add CMake instructions. - Use the releases page to create the tag based on a verified commit.
http_archive
rules in WORKSPACE all reference master and don't include a sha256. This leads to non-reproducible builds.Request specific versions instead and include sha256's as described in the Bazel docs.
The text was updated successfully, but these errors were encountered: